Github user ioana-delaney commented on the issue:
https://github.com/apache/spark/pull/13867
@hvanhovell Would you please let me know if you agree with my previous
reply?
An alternative design is to remove the try-catch expression from
resolveOuterReferences() altogether. The two try-catch expressions (i.e.
try-catch in withPosition() and the explicit try-catch in
resolveOuterReferences()) are used in the original design. The purpose of the
try-catch in the resolveOuterReferences() is to intercept any exceptions coming
from resolve() and override them by returning the unresolved attribute. One
exception is "ambiguous reference" but, in my opinion, that should be thrown as
an exception since it is an incorrect sql at this point. Therefore, an
alternative design is to remove the try-catch in the resolveOuterReference()
and let withPosition() capture any exceptions, including the new one. Let me
know your opinion. Or we can go with my previous proposal, which aligns with
the original design.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
