Github user koeninger commented on the issue: https://github.com/apache/spark/pull/11863 You do need CanCommitOffsets because DirectKafkaInputDstream is now private, so otherwise you have nothing to cast to to access that method. On Jun 29, 2016 7:11 PM, "Tathagata Das" <notificati...@github.com> wrote: > Overall, this is looking good. Two high level points. > > 1. > > Now we have two subprojects both creating > org.apache.spark.streaming.kafka.KafkaUtils. I think this is going to cause > problems downstream in the docs and stuff. Also it will be hard for user to > disambiguate whats being used. So I propose changing the package name for > the new one to o.a.s.streaming.kafka010. All the new classes will be > in that package. > 2. > > Don't need CanCommitOffsets. > 3. > > We need a whole lot of new docs, especially updates in the streaming > kafka integration guide. That will be a different PR. Could you start > working on that? > > â > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/spark/pull/11863#issuecomment-229525922>, or mute > the thread > <https://github.com/notifications/unsubscribe/AAGABz0T__MSSwsM6znRLSwfh8UwC1Kcks5qQwmqgaJpZM4H1Pg1> > . >
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org