Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13989#discussion_r69083486
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala
---
@@ -265,6 +265,11 @@ abstract class LogicalPlan extends
QueryPlan[LogicalPlan] with Logging {
s"Reference '$name' is ambiguous, could be: $referenceNames.")
}
}
+
+ /**
+ * Invalidates any metadata cached in the plan recursively.
+ */
+ def refresh(): Unit = children.foreach(_.refresh())
--- End diff --
`children.foreach(_.refresh())` isn't tail recursive. Using a non-tail
recursion here is probably fine since this isn't a critical path. As
@petermaxlee said, we are already using recursion to handle `TreeNode`s
everywhere with the assumption that such trees are relatively shallow. We do
need to pay attention when using recursion in other places though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
