Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13680#discussion_r69147706
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeArrayData.java
---
@@ -59,21 +66,16 @@
// The 4-bytes header of `numElements` is also included.
private int sizeInBytes;
- public Object getBaseObject() { return baseObject; }
- public long getBaseOffset() { return baseOffset; }
- public int getSizeInBytes() { return sizeInBytes; }
+ /** The width of the null tracking bit set plus `numElements`, in bytes
*/
+ private int headerInBytes;
- private int getElementOffset(int ordinal) {
- return Platform.getInt(baseObject, baseOffset + 4 + ordinal * 4L);
+ private long getFieldOffset(int ordinal, int elementSize) {
--- End diff --
for array, we should call it `element` instead of `field`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
