Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/13981#discussion_r69298648
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/DecisionTreeRegressorSuite.scala
---
@@ -96,6 +108,15 @@ class DecisionTreeRegressorSuite
assert(variance === expectedVariance,
s"Expected variance $expectedVariance but got $variance.")
}
+
+ val toyDF = TreeTests.setMetadata(toyData, Map.empty[Int, Int], 0)
+ dt.setMaxDepth(1)
+ .setMaxBins(6)
+ .setSeed(0)
+ val expectVariances =
dt.fit(toyDF).transform(toyDF).select("variance").collect().map {
--- End diff --
`expectedVariances` and `trueVariances` are mixed up here. Expected should
be the theoretical value computed below. Also, it would be good to leave a
comment explaining where those expected values came from.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
