Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14033#discussion_r69407065 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala --- @@ -94,6 +96,61 @@ case class UserDefinedGenerator( } /** + * Separate v1, ..., vk into n rows. Each row will have k/n columns. n must be constant. + * {{{ + * SELECT stack(2, 1, 2, 3)) -> + * 1 2 + * 3 NULL + * }}} + */ +@ExpressionDescription( + usage = "_FUNC_(n, v1, ..., vk) - Separate v1, ..., vk into n rows.", + extended = "> SELECT _FUNC_(2, 1, 2, 3);\n [1,2]\n [3,null]") +case class Stack(children: Seq[Expression]) + extends Expression with Generator with ImplicitCastInputTypes with CodegenFallback { + + override def inputTypes: Seq[DataType] = + Seq(IntegerType) ++ Seq.fill(children.length - 1)(children.tail.head.dataType) + + override def checkInputDataTypes(): TypeCheckResult = { --- End diff -- Thank you for review again, @cloud-fan . For this, I added type casting tests here. https://github.com/apache/spark/pull/14033/files#diff-a2587541e08bf6e23df33738488d070aR30 Did I miss something there?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org