Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13818#discussion_r69448268
  
    --- Diff: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/parquetSuites.scala ---
    @@ -425,6 +425,28 @@ class ParquetMetastoreSuite extends 
ParquetPartitioningTest {
         }
       }
     
    +  test("SPARK-15968: nonempty partitioned metastore Parquet table lookup 
should use cached " +
    +      "relation") {
    +    withTable("partitioned") {
    +      sql(
    +        s"""CREATE TABLE partitioned (
    +           | key INT,
    +           | value STRING
    +           |)
    +           |PARTITIONED BY (part INT)
    +           |STORED AS PARQUET
    +       """.stripMargin)
    +      sql("INSERT INTO TABLE partitioned PARTITION(part=0) SELECT 1 as 
key, 'one' as value")
    +
    +      // First lookup fills the cache
    +      val r1 = collectHadoopFsRelation (table("partitioned"))
    +      // Second lookup should reuse the cache
    +      val r2 = collectHadoopFsRelation (table("partitioned"))
    --- End diff --
    
    Nit: Remove space before `(`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to