Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14034#discussion_r69499892
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
 ---
    @@ -46,6 +46,15 @@ trait CheckAnalysis extends PredicateHelper {
         }).length > 1
       }
     
    +  private def checkLimitClause(limitExpr: Expression): Unit = {
    +    val numRows = limitExpr.eval().asInstanceOf[Int]
    --- End diff --
    
    We do not support non-foldable limit clauses.
    
https://github.com/apache/spark/blob/d063898bebaaf4ec2aad24c3ac70aabdbf97a190/sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala#L67-L89
    
https://github.com/apache/spark/blob/d063898bebaaf4ec2aad24c3ac70aabdbf97a190/sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala#L398-L401
    
    But,,, we do not issue an exception if users do it. Thus, the error we got 
is strange:
    ```
    assertion failed: No plan for GlobalLimit (_nondeterministic#203 > 0.2)
    +- Project [key#11, value#12, rand(-1441968339187861415) AS 
_nondeterministic#203]
       +- LocalLimit (_nondeterministic#202 > 0.2)
          +- Project [key#11, value#12, rand(-1308350387169017676) AS 
_nondeterministic#202]
             +- LogicalRDD [key#11, value#12]
    
    java.lang.AssertionError: assertion failed: No plan for GlobalLimit 
(_nondeterministic#203 > 0.2)
    +- Project [key#11, value#12, rand(-1441968339187861415) AS 
_nondeterministic#203]
       +- LocalLimit (_nondeterministic#202 > 0.2)
          +- Project [key#11, value#12, rand(-1308350387169017676) AS 
_nondeterministic#202]
             +- LogicalRDD [key#11, value#12]
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to