Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14053#discussion_r69672781
  
    --- Diff: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/parquetSuites.scala ---
    @@ -716,6 +717,39 @@ class ParquetSourceSuite extends 
ParquetPartitioningTest {
         }
       }
     
    +  test("Alias used in converted data source tables") {
    --- End diff --
    
    Do we really need a test for it? This PR looks like a cleanup to me, and 
making one `Subquery` into two is not our target, making the code cleaner is.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to