Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13894#discussion_r69809083
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala ---
@@ -191,7 +194,8 @@ object CrossValidator extends
MLReadable[CrossValidator] {
/**
* :: Experimental ::
- * Model from k-fold cross validation.
+ * CrossValidatorModel contains the model that achieved the highest
average cross-validation
--- End diff --
I think we could maybe make this a bit clearer. Maybe something like:
"CrossValidatorModel contains the model with the highest average cross
validation metric across folds and uses this model to transform input data.
CrossValidatorModel also tracks the metrics for each param map evaluated."
This way its clear that it contains both the best model and the metrics, as
well as uses the best model if asked to predict/transform any data. What do you
think?
(Of course if we change it here we would want to have the corresponding
change occur in Python).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
