Github user petermaxlee commented on a diff in the pull request:
https://github.com/apache/spark/pull/13969#discussion_r69856576
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/JavaMethodReflectSuite.scala
---
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.catalyst.expressions
+
+import org.apache.spark.SparkFunSuite
+import org.apache.spark.sql.types.{IntegerType, StringType}
+
+/**
+ * Test suite for [[JavaMethodReflect]] and its companion object.
+ */
+class JavaMethodReflectSuite extends SparkFunSuite with
ExpressionEvalHelper {
+
+ import JavaMethodReflect._
+
+ private val staticClassName = ReflectStaticClass.getClass.getName
+ private val dynamicClassName = classOf[ReflectClass].getName
+
+ test("findMethod via reflection for static methods") {
+ for (className <- Seq(staticClassName, dynamicClassName)) {
+ assert(findMethod(className, "method1", Seq.empty).exists(_.getName
== "method1"))
+ assert(findMethod(className, "method2", Seq(IntegerType)).isDefined)
+ assert(findMethod(className, "method3", Seq(IntegerType)).isDefined)
+ assert(findMethod(className, "method4", Seq(IntegerType,
StringType)).isDefined)
+ }
+ }
+
+ test("instantiate class via reflection") {
+ // Should succeed since the following two should have no-arg ctor.
+ assert(instantiate(dynamicClassName).isDefined)
+ assert(instantiate(staticClassName).isDefined)
+
+ // Should fail since there is no no-arg ctor.
+ assert(instantiate(classOf[ReflectClass1].getName).isEmpty)
+ }
+
+ test("findMethod for a JDK library") {
+ assert(findMethod(classOf[java.util.UUID].getName, "randomUUID",
Seq.empty).isDefined)
+ }
+
+ test("type checking") {
+ assert(JavaMethodReflect(Seq.empty).checkInputDataTypes().isFailure)
+
assert(JavaMethodReflect(Seq(Literal(staticClassName))).checkInputDataTypes().isFailure)
+ assert(
+ JavaMethodReflect(Seq(Literal(staticClassName),
Literal(1))).checkInputDataTypes().isFailure)
+
+ assert(reflectExpr(staticClassName,
"method1").checkInputDataTypes().isSuccess)
+ }
+
+ test("invoking methods using acceptable types") {
+ for (className <- Seq(staticClassName, dynamicClassName)) {
+ checkEvaluation(reflectExpr(className, "method1"), "m1")
+ checkEvaluation(reflectExpr(className, "method2", 2), "m2")
+ checkEvaluation(reflectExpr(className, "method3", 3), "m3")
+ checkEvaluation(reflectExpr(className, "method4", 4, "four"),
"m4four")
+ }
+ }
+
+ private def reflectExpr(className: String, methodName: String, args:
Any*): JavaMethodReflect = {
--- End diff --
Why?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
