Github user shivaram commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14096#discussion_r70006591
  
    --- Diff: R/pkg/inst/tests/testthat/test_sparkSQL.R ---
    @@ -1804,11 +1804,11 @@ test_that("describe() and summarize() on a 
DataFrame", {
       expect_equal(collect(stats)[2, "age"], "24.5")
       expect_equal(collect(stats)[3, "age"], "7.7781745930520225")
       stats <- describe(df)
    -  expect_equal(collect(stats)[4, "name"], "Andy")
    +  expect_equal(columns(stats), c("summary", "age"))
    --- End diff --
    
    Sorry one last thing - instead of removing the previous test can we add a 
new assert ? 
    Also maybe can we add the failing test case from the JIRA as a new test 
case ? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to