Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13890#discussion_r70025823
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ExistingRDD.scala ---
@@ -74,13 +74,71 @@ object RDDConversions {
}
}
+private[sql] object ExternalRDD {
+
+ def apply[T: Encoder](rdd: RDD[T])(session: SparkSession): LogicalPlan =
{
--- End diff --
Actually I'm not sure why we curry the constructor either. Since `RDDScan`
does it, it's ok we follow it. But for this apply `method`, I don't see the
value of doing it. cc @yhuai
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
