Github user petermaxlee commented on a diff in the pull request:
https://github.com/apache/spark/pull/14103#discussion_r70030786
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -41,7 +41,12 @@ trait ExpressionEvalHelper extends
GeneratorDrivenPropertyChecks {
}
protected def checkEvaluation(
- expression: => Expression, expected: Any, inputRow: InternalRow =
EmptyRow): Unit = {
+ originalExpr: => Expression, expected: Any, inputRow: InternalRow =
EmptyRow): Unit = {
+ val expression = originalExpr match {
+ case replaceable: RuntimeReplaceable => replaceable.replaced
--- End diff --
They are already tested in the end-to-end tests. I'm not sure if expression
level unit tests are useful, given they are replaced in the optimizer.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
