Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/1822#discussion_r16196620
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/hiveUdfs.scala
---
@@ -340,4 +340,10 @@ private[hive] case class HiveUdafFunction(
val inputs = inputProjection(input).asInstanceOf[Seq[AnyRef]].toArray
function.iterate(buffer, inputs)
}
+
+ //hiveUdaf does not support external aggregate, for HiveUdafFunction
need to spill to disk,
+ //and all the vals above need Serializable
+ override def merge(input: AggregateFunction): Unit = {
+ throw new NotImplementedError(s"HiveUdaf does not support external
aggregate")
--- End diff --
I think we are going to have to figure out something that works here.
Perhaps we can use `SerializableWritable` or something?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
