Github user sethah commented on the issue:
https://github.com/apache/spark/pull/14109
ping @dbtsai
I implemented this patch using `@transient` as you suggested. I ran into an
obscure complication using `@transient` with `unapply` method which is not
obvious. While I understand that it is nice to keep the `add` method signature
unchanged, I think you can argue that it is more appropriate to pass the
coefficients and featuresStd arrays directly to the method since it is the only
place in the class they are used. Add that to the fact that the `@transient`
approach has a more confusing implementation and could potentially be
unknowningly undone by future developers, it may not be the best approach. I am
open to feedback/suggestions. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
