Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14034#discussion_r70183958 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -46,6 +46,20 @@ trait CheckAnalysis extends PredicateHelper { }).length > 1 } + private def checkLimitClause(limitExpr: Expression): Unit = { + if (!limitExpr.foldable) { --- End diff -- this may be more readable: ``` limitExpr match { case e if !e.foldable => fail(...) case e if e.dataType != IntegerType => fail("the limit expression must be int type, but got ${e.dataType.simpleString}") case e if e.eval() < 0 => fail(...) case e => } ```
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org