Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/1658#issuecomment-52112757
Hey, sorry for taking a bit of time to get back to this (I've been looking
at 1.1 stuff), but I have a few comments on the API:
- Do we need both a stream API and a byte array one? I'd personally offer
only the stream one because it's less likely to cause crashes (with the other
one there's a risk of OutOfMemoryError).
- For the files vs fixed-length records, maybe we can call the methods
`binaryFiles` and `binaryRecords`.
- Are you planning to create saveAsBinaryFiles / saveAsBinaryRecords too?
We don't have to have it in this PR but it would be useful.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
