Github user hvanhovell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14136#discussion_r70243206
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
    @@ -536,6 +536,25 @@ object functions {
       def min(columnName: String): Column = min(Column(columnName))
     
       /**
    +   * Aggregate function: returns the exact percentile(s) of the expression 
in a group at pc with
    +   * range in [0, 1].
    +   *
    +   * @group agg_funcs
    +   * @since 2.1.0
    +   */
    +  def percentile(e: Column, pc: Seq[Double]): Column =
    +    withAggregateFunction {Percentile(e.expr, pc)}
    --- End diff --
    
    Style: match the other code, e.g.: `def min(e: Column): Column = 
withAggregateFunction { Min(e.expr) }`



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to