Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r70300858
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -347,6 +347,14 @@ querySpecification
windows?)
;
+hint
+ : '/*+' mapJoinHint '*/'
+ ;
+
+mapJoinHint
+ : MAPJOIN '(' broadcastedTables+=tableIdentifier (','
broadcastedTables+=tableIdentifier)* ')'
--- End diff --
Can we move the logic somewhere else that's not in the parser rule? It'd be
great if we don't need to modify the parser rule in order to support
"broadcast" or "broadcast join". Even moving it into the parser itself (that is
not parser rule could work).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
