Github user hvanhovell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14114#discussion_r70301759
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/internal/CatalogImpl.scala ---
    @@ -138,7 +138,7 @@ class CatalogImpl(sparkSession: SparkSession) extends 
Catalog {
        */
       @throws[AnalysisException]("table does not exist")
       override def listColumns(tableName: String): Dataset[Column] = {
    --- End diff --
    
    This changes the contract of the `listColumns(...)` function. It now 
returns either a temporary view or a table in the current database. We have to 
document this! What happens when we have temporary table with the same name as 
a table in the current database?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to