Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/13831#discussion_r70322649
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala ---
@@ -643,6 +694,21 @@ private[client] class Shim_v0_14 extends Shim_v0_13 {
numDP: JInteger, holdDDLTime: JBoolean, listBucketingEnabled:
JBoolean, JBoolean.FALSE)
}
+ override def dropTable(
+ hive: Hive,
+ dbName: String,
+ tableName: String,
+ deleteData: Boolean,
+ ignoreIfNotExists: Boolean,
+ purge: Boolean): Unit = {
+ try {
+ dropTableMethod.invoke(hive, dbName, tableName, deleteData: JBoolean,
+ ignoreIfNotExists: JBoolean, purge: JBoolean)
+ } catch {
+ case e: InvocationTargetException => throw e.getCause()
--- End diff --
just curious, why include this extra handling here? its not used on any of
the other reflective calls. I'm guessing it just makes the exception a little
cleaner, so really could be everywhere?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
