Github user jkbradley commented on the issue:

    https://github.com/apache/spark/pull/14112
  
    What will happen in the future if the model changes, such as storing 
another val?  We will need to update the model loading logic and should follow 
different code paths for models saved in 1.6 vs. 2.x.  I'd recommend we isolate 
the 1.6 code path by checking ```metadata.sparkVersion```.  Even though a 
single code paths works for 1.6 and 2.0, isolating the special logic for 1.6 
might make it easier to update in the future.  What do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to