Github user sharkdtu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14088#discussion_r70362297
  
    --- Diff: 
yarn/src/test/scala/org/apache/spark/deploy/yarn/YarnClusterSuite.scala ---
    @@ -274,6 +288,37 @@ private object YarnClusterDriverWithFailure extends 
Logging with Matchers {
       }
     }
     
    +private object YarnClusterDriverUseSparkHadoopUtilConf extends Logging 
with Matchers {
    +  def main(args: Array[String]): Unit = {
    +    if (args.length != 2) {
    +      // scalastyle:off println
    +      System.err.println(
    +        s"""
    +        |Invalid command line: ${args.mkString(" ")}
    +        |
    +        |Usage: YarnClusterDriverUseSparkHadoopUtilConf 
[propertyKey=value] [result file]
    +        """.stripMargin)
    +      // scalastyle:on println
    +      System.exit(1)
    +    }
    +
    +    val sc = new SparkContext(new SparkConf()
    +      .set("spark.extraListeners", classOf[SaveExecutorInfo].getName)
    +      .setAppName("yarn test using SparkHadoopUtil's conf"))
    +
    +    val propertyKeyValue = args(0).split("=")
    +    val status = new File(args(1))
    +    var result = "failure"
    +    try {
    +      SparkHadoopUtil.get.conf.get(propertyKeyValue(0).drop(13)) should be 
(propertyKeyValue(1))
    --- End diff --
    
    it means drop `spark.hadoop.`. it may be hard to understand and i will fix 
it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to