Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14155#discussion_r70545811
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -327,6 +326,32 @@ class SparkSqlAstBuilder(conf: SQLConf) extends
AstBuilder {
.getOrElse(Array.empty[String])
val bucketSpec = Option(ctx.bucketSpec()).map(visitBucketSpec)
+ val path = new CaseInsensitiveMap(options).get("path")
+ val storage = CatalogStorageFormat(path, Some(provider), options)
+ val columns =
Option(ctx.colTypeList()).toSeq.flatMap(visitCatalogColumns)
--- End diff --
yea definitely. SQL is just one of the API entries, we should find a centre
place to do error handling so all APIs can benefit
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
