Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/14098
Thanks for doing this! Overall it's pretty nice. A few high level comments:
1. It might be better to split the whole example file into several methods,
as what #14119 did. In this way, the code can be easier to follow, and we can
avoid using variable names like `df1`, `df2`, and `df3`.
2. Could you please add actual output after each `.show()` call? I think
you can simply copy them from #14119.
3. Could you please update example snippet label names to match those used
in #14119?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
