Github user lianhuiwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/14036#discussion_r70660445
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
---
@@ -207,20 +207,12 @@ case class Multiply(left: Expression, right:
Expression)
protected override def nullSafeEval(input1: Any, input2: Any): Any =
numeric.times(input1, input2)
}
-@ExpressionDescription(
- usage = "a _FUNC_ b - Divides a by b.",
- extended = "> SELECT 3 _FUNC_ 2;\n 1.5")
-case class Divide(left: Expression, right: Expression)
- extends BinaryArithmetic with NullIntolerant {
-
- override def inputType: AbstractDataType = TypeCollection(DoubleType,
DecimalType)
-
- override def symbol: String = "/"
--- End diff --
we need to keep symbol because it is very useful for BinaryOperator'
sqlOperator() and sql()
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
