Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/14162#discussion_r70687988
--- Diff:
common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleService.java
---
@@ -70,6 +70,11 @@
private static final String RECOVERY_FILE_NAME =
"registeredExecutor.ldb";
+ // Whether failure during service initialization should stop the NM.
+ @VisibleForTesting
+ static final String STOP_ON_FAILURE_KEY =
"spark.yarn.shuffle.stopOnFailure";
--- End diff --
it would be nice to document this so others now about it. There is a
section in job scheduling doc about the external shuffle service, otherwise
maybe just put in the yarn section. We probably should have pointer from yarn
section to the job scheduler section or just a standalone section on the
shuffle service, but that is a different issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
