Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/14192#discussion_r70744731
--- Diff: R/pkg/R/window.R ---
@@ -17,23 +17,23 @@
# window.R - Utility functions for defining window in DataFrames
-#' window.partitionBy
+#' windowPartitionBy
#'
#' Creates a WindowSpec with the partitioning defined.
#'
-#' @rdname window.partitionBy
-#' @name window.partitionBy
+#' @rdname windowPartitionBy
+#' @name windowPartitionBy
#' @export
#' @examples
#' \dontrun{
-#' ws <- window.partitionBy("key1", "key2")
+#' ws <- windowPartitionBy("key1", "key2")
#' df1 <- select(df, over(lead("value", 1), ws))
#'
-#' ws <- window.partitionBy(df$key1, df$key2)
+#' ws <- windowPartitionBy(df$key1, df$key2)
#' df1 <- select(df, over(lead("value", 1), ws))
#' }
-#' @note window.partitionBy(character) since 2.0.0
-setMethod("window.partitionBy",
+#' @note windowPartitionBy(character) since 2.0.0
+setMethod("windowPartitionBy",
--- End diff --
minor comment: Can we document the parameter `@param col` that is in all
the 4 functions ? That'll also remove some of the CRAN warnings
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
