Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14132#discussion_r70866586 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1774,6 +1775,39 @@ class Analyzer( } /** + * Substitute Hints. + */ + object SubstituteHint extends Rule[LogicalPlan] { + def apply(plan: LogicalPlan): LogicalPlan = plan transform { + case logical: LogicalPlan => logical transformDown { + // MAPJOIN + case h @ Hint(name, parameters, child) if name.equalsIgnoreCase("MAPJOIN") => + var resolvedChild = child + for (table <- parameters) { + var stop = false + resolvedChild = child.transformDown { + case r @ BroadcastHint(UnresolvedRelation(_, _)) => r + case r @ UnresolvedRelation(t, _) if !stop && t.table == table => + stop = true + BroadcastHint(r) + } + } + resolvedChild + // BROADCAST (LEFT|RIGHT) + case h @ Hint(name, parameters, j @ Join(left, _, _, _)) + if name.equalsIgnoreCase("BROADCAST_LEFT") => + j.copy(left = BroadcastHint(left)) + case h @ Hint(name, parameters, j @ Join(_, right, _, _)) + if name.equalsIgnoreCase("BROADCAST_RIGHT") => + j.copy(right = BroadcastHint(right)) + + // Remove unrecognized hint + case Hint(_, _, child) => child --- End diff -- At least tell the user he wants something we don't understand?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org