Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14132#discussion_r70883389 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -509,6 +512,23 @@ class AstBuilder extends SqlBaseBaseVisitor[AnyRef] with Logging { } /** + * Add a Hint to a logical plan. + */ + private def withHints( + ctx: HintContext, + relation: LogicalPlan): LogicalPlan = withOrigin(ctx) { + val stmt = ctx.hintStatement + val name = stmt.hintName.getText.toUpperCase + if (stmt.identifierList != null) { + Hint(name, visitIdentifierList(stmt.identifierList), relation) + } else if (stmt.parameters != null) { + Hint(name, stmt.parameters.asScala.map(_.getText), relation) + } else { + Hint(name, Seq.empty[String], relation) --- End diff -- I thought it happens in `/*+ SOMEHINT */`. Let me check and add testcase, too.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org