Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/1935#discussion_r16221600
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
---
@@ -280,7 +280,7 @@ abstract class TreeNode[BaseType <: TreeNode[BaseType]]
{
*/
def makeCopy(newArgs: Array[AnyRef]): this.type = attachTree(this,
"makeCopy") {
try {
- val defaultCtor = getClass.getConstructors.head
+ val defaultCtor =
getClass.getConstructors.find(_.getParameterTypes.size != 0).head
--- End diff --
Will that cause exception if its subclass only contains the no-args
constructor? e.g. the class `Rand`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
