Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/14179#discussion_r71073655 --- Diff: R/pkg/R/sparkR.R --- @@ -155,6 +155,10 @@ sparkR.sparkContext <- function( existingPort <- Sys.getenv("EXISTING_SPARKR_BACKEND_PORT", "") if (existingPort != "") { + if (length(sparkPackages) != 0) { --- End diff -- I looked into this and we get the unit test error because the check here isn't correct. So we get `sparkPackages` as `""` and in R the length of empty string is not 0 but 1. ``` > length("") [1] 1 ``` I think we should instead check the length of `packages` to be zero ? (`packages` is a list created by splitting the input in `processSparkPackages`)
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org