Github user sun-rui commented on a diff in the pull request:
https://github.com/apache/spark/pull/14175#discussion_r71095619
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala
---
@@ -552,7 +552,9 @@ private[spark] class MesosCoarseGrainedSchedulerBackend(
taskId: String,
reason: String): Unit = {
stateLock.synchronized {
- removeExecutor(taskId, SlaveLost(reason))
+ if (!stopCalled) {
--- End diff --
If we add the guard in the parent class, namely
CoarseGrainedSchedulerBackend, what's the appropriate behavior of the guard?
Silently ignore all message requests after stop() is called and log warnings,
or throw an exception? If latter, then the call to removeExecutor has to be
wrapped with a try.
Since the call to removeExecutor() is done in
MesosCoarseGrainedSchedulerBackend, I think current fix is simpler and
reasonable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
