Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/14102#discussion_r71099098
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JSONOptions.scala
---
@@ -51,7 +53,8 @@ private[sql] class JSONOptions(
parameters.get("allowBackslashEscapingAnyCharacter").map(_.toBoolean).getOrElse(false)
val compressionCodec =
parameters.get("compression").map(CompressionCodecs.getCodecClassName)
private val parseMode = parameters.getOrElse("mode", "PERMISSIVE")
- val columnNameOfCorruptRecord =
parameters.get("columnNameOfCorruptRecord")
+ val columnNameOfCorruptRecord =
+ parameters.getOrElse("columnNameOfCorruptRecord",
sqlConf.columnNameOfCorruptRecord)
--- End diff --
Oh, actually, the reason was not only to remove duplicated logics. Another
reason is that we are passing `columnNameOfCorruptRecords` to
`InferSchema.infer(...)` and `JacksonParser.parse(...)`
```scala
def infer(
json: RDD[String],
columnNameOfCorruptRecords: String,
configOptions: JSONOptions): StructType = {
...
```
```scala
def parse(
input: RDD[String],
schema: StructType,
columnNameOfCorruptRecords: String,
configOptions: JSONOptions): RDD[InternalRow] = {
...
```
although `columnNameOfCorruptRecords` is an option in `JSONOptions`. I
would revert this change if it still does not sound good but I just wanted to
let you know just in case.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
