Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14235#discussion_r71216783
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/catalyst/SQLBuilder.scala ---
@@ -45,7 +46,12 @@ class SQLBuilder(logicalPlan: LogicalPlan) extends
Logging {
def this(df: Dataset[_]) = this(df.queryExecution.analyzed)
private val nextSubqueryId = new AtomicLong(0)
+ private val nextGenAttrId = new AtomicLong(0)
private def newSubqueryName(): String =
s"gen_subquery_${nextSubqueryId.getAndIncrement()}"
+ private val exprIdMap: Map[Long, Long] = Map.empty[Long, Long]
+ private def normalizedName(n: NamedExpression): String = synchronized {
+ "gen_attr_" + exprIdMap.getOrElseUpdate(n.exprId.id,
nextGenAttrId.getAndIncrement())
+ }
--- End diff --
Now, the generated attributes also have stable identifiers like generated
subqueries.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
