Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/12944#discussion_r71251245
--- Diff:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockResolver.java
---
@@ -66,6 +67,16 @@
@VisibleForTesting
final ConcurrentMap<AppExecId, ExecutorShuffleInfo> executors;
+ /**
+ * Caches index file information so that we can avoid open/close the
index files
+ * for each block fetch.
+ */
+ private final ShuffleIndexCache shuffleIndexCache;
+
+ // Max number of entries to keep in the index cache.
+ private static final String SPARK_SHUFFLE_SERVICE_INDEX_CACHE_ENTRIES =
"spark.shuffle.service.index.cache.entries";
+ private static final int
DEFAULT_SPARK_SHUFFLE_SERVICE_INDEX_CACHE_ENTRIES = 1024;
--- End diff --
This conf seems a little out of place. Can it be co-located with the other
spark.shuffle.* configs?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
