Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14256#discussion_r71316160
--- Diff: core/src/test/scala/org/apache/spark/rdd/PipedRDDSuite.scala ---
@@ -51,6 +51,22 @@ class PipedRDDSuite extends SparkFunSuite with
SharedSparkContext {
}
}
+ test("basic pipe with tokenization") {
+ if (testCommandAvailable("wc")) {
+ val nums = sc.makeRDD(Array(1, 2, 3, 4), 2)
+
+ // verify that both RDD.pipe(command: String) and RDD.pipe(command:
String, env) work good
+ for (piped <- Seq(nums.pipe("wc -l"), nums.pipe("wc -l", Map[String,
String]()))) {
--- End diff --
You know, we actually had no tests testing `pipe(String)`! This is one.
Feel free to add even the most basic tests exercising this method as it
would have caught the underlying error that caused the infinite recursion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
