Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r71464346
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/catalyst/SQLBuilder.scala ---
@@ -356,8 +372,14 @@ class SQLBuilder(logicalPlan: LogicalPlan) extends
Logging {
}
}
+ val broadcastHint = project match {
+ case p @ Project(projectList, Hint("BROADCAST", tables, child)) =>
+ if (tables.nonEmpty) s"/*+ MAPJOIN(${tables.mkString(", ")}) */"
else ""
+ case _ => ""
+ }
build(
"SELECT",
+ broadcastHint,
--- End diff --
"SELECT" occurs in the followings. But, I didn't added meaning-logic based
on the testcases.
- aggregateToSQL
- generateToSQL => This has only "SELECT 1"
- groupingSetToSQL
- projectToSQL
- windowToSQL
I think the test coverage enough due to it generates the above cases. If
you suggests more testcases, I welcome. I like robustness both for this PR and
for the future.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
