GitHub user lw-lin opened a pull request:
https://github.com/apache/spark/pull/14280
[SPARK-16515][SQL][FOLLOW-UP] Fix test `script` on OS X/Windows...
## Problem
OS X's `sed` doesn't understand `\t` at all, so this `script` test would
fail:
```
== Results ==
!== Correct Answer - 2 == == Spark Answer - 2 ==
![x1_y1] [x1]
![x2_y2] [x2]
```
In addition, this `script` test would also fail on systems like Windows
where we couldn't be able to invoke `bash` or `echo ... | awk ...`.
## What changes were proposed in this pull request?
This patch
- switches from `sed` to `awk` for replacing `\t` purpose
- adds command guards so that the `script` test would pass on systems like
Windows
## How was this patch tested?
- Jenkins
- Manually verified tests pass on OS X
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lw-lin/spark osx-sed
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/14280.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #14280
----
commit 35773defdcc1ed0a4f6044e805fab69cf5323df6
Author: Liwei Lin <lwl...@gmail.com>
Date: 2016-07-20T06:56:12Z
`sed` -> `awk`
commit dc39c98a8c624ee35f8df1fb824a85f7c4c3741e
Author: Liwei Lin <lwl...@gmail.com>
Date: 2016-07-20T07:17:53Z
Add `testCommandAvailable` gards
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
