Github user yhuai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14284#discussion_r71488537
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
 ---
    @@ -382,7 +382,7 @@ abstract class OffsetWindowFunction
      *
      * @param input expression to evaluate 'offset' rows after the current row.
      * @param offset rows to jump ahead in the partition.
    - * @param default to use when the input value is null or when the offset 
is larger than the window.
    + * @param default to use when the offset is larger than the window.
    --- End diff --
    
    @hvanhovell what was the reason that we changed the behavior of lead and 
lag on if they respect null values?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to