Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14258#discussion_r71594099
  
    --- Diff: R/pkg/R/install.R ---
    @@ -0,0 +1,84 @@
    +#
    +# Licensed to the Apache Software Foundation (ASF) under one or more
    +# contributor license agreements.  See the NOTICE file distributed with
    +# this work for additional information regarding copyright ownership.
    +# The ASF licenses this file to You under the Apache License, Version 2.0
    +# (the "License"); you may not use this file except in compliance with
    +# the License.  You may obtain a copy of the License at
    +#
    +#    http://www.apache.org/licenses/LICENSE-2.0
    +#
    +# Unless required by applicable law or agreed to in writing, software
    +# distributed under the License is distributed on an "AS IS" BASIS,
    +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +# See the License for the specific language governing permissions and
    +# limitations under the License.
    +#
    +
    +# Functions to install Spark in case the user directly downloads SparkR
    +# from CRAN.
    +
    +#' Download and Install Spark to Local Directory
    +#' 
    +#' \code{install_spark} downloads and installs Spark to local directory if
    +#' it is not found. The Spark version we use is 2.0.0 (preview). Users can
    +#' specify a desired Hadoop version, the remote site, and the directory 
where
    +#' the package is installed locally.
    +#'
    +#' @param hadoop_version Version of Hadoop to install. 2.3, 2.4, 2.6,
    +#'        and 2.7 (default)
    +#' @param url the base URL of the repositories to use
    +#' @param local_dir local directory that Spark is installed to
    +#' @rdname install_spark
    +#' @name install_spark
    +#' @export
    +#' @examples
    +#'\dontrun{
    +#' install_spark()
    +#'}
    +#' @note install_spark since 2.1.0
    +install_spark <- function(hadoop_version = NULL, url = NULL, local_dir = 
NULL) {
    +  version <- paste0("spark-", spark_version_default())
    +  hadoop_version <- hadoop_version_default()
    --- End diff --
    
    if you mean 
[this](https://github.com/apache/spark/pull/14258#discussion_r71426992) I 
wasn't sure csv was a good suggestion but hardcoding a list in .R would be 
problematic.
    
    I think this bring us into the question/policy around compatibility - 
should be follow [semantic versioning](http://semver.org/)? like many other 
package managers, we could say we support "2.*" and that the Spark Core API 
interfacing with SparkR will need to be fully backward compatible.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to