Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14284#discussion_r71598678
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/SQLWindowFunctionSuite.scala
---
@@ -357,14 +356,59 @@ class SQLWindowFunctionSuite extends QueryTest with
SQLTestUtils with TestHiveSi
}
test("SPARK-7595: Window will cause resolve failed with self join") {
- sql("SELECT * FROM src") // Force loading of src table.
--- End diff --
For this test, I disabled the fix
(https://github.com/apache/spark/pull/6114/files) and checked that it does fail
the analysis because analyzer fails to resolve conflicting references in Join.
So, this test is still valid after my change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
