GitHub user cloud-fan opened a pull request:

    https://github.com/apache/spark/pull/14297

    [SPARK-16660][SQL] CreateViewCommand should not take CatalogTable

    ## What changes were proposed in this pull request?
    
    `CreateViewCommand` only needs some information of a `CatalogTable`, but 
not all of them. We have some tricks(e.g. we need to check the table type is 
`VIEW`, we need to make `CatalogColumn.dataType` nullable) to allow it to take 
a `CatalogTable`.
    This PR cleans it up and only pass in necessary information to 
`CreateViewCommand`. 
    
    
    ## How was this patch tested?
    
    existing tests.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloud-fan/spark minor2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/14297.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #14297
    
----
commit 26312b91109823de199a6dad031572a5d50f6d3c
Author: Wenchen Fan <wenc...@databricks.com>
Date:   2016-07-21T06:29:09Z

    CreateViewCommand should not take CatalogTable

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to