Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14210#discussion_r71667341
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/InsertIntoHadoopFsRelationCommand.scala
---
@@ -75,7 +75,12 @@ private[sql] case class
InsertIntoHadoopFsRelationCommand(
case (x, ys) if ys.length > 1 => "\"" + x + "\""
}.mkString(", ")
throw new AnalysisException(s"Duplicate column(s) :
$duplicateColumns found, " +
- s"cannot save to file.")
+ "cannot save to file.")
+ }
+
+ if (bucketSpec.exists(_.numBuckets <= 0)) {
--- End diff --
is this the only place we need to check? what if we put this check inside
the constructor of `BucketSpec`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
