Github user ajbozarth commented on a diff in the pull request:
https://github.com/apache/spark/pull/14204#discussion_r71817036
--- Diff: core/src/test/scala/org/apache/spark/util/JsonProtocolSuite.scala
---
@@ -73,13 +73,15 @@ class JsonProtocolSuite extends SparkFunSuite {
BlockManagerId("Scarce", "to be counted...", 100))
val unpersistRdd = SparkListenerUnpersistRDD(12345)
val logUrlMap = Map("stderr" -> "mystderr", "stdout" ->
"mystdout").toMap
+ val workerUrlMap = Map("url" -> "spark://Worker@192.168.1.104:32790",
+ "ui_url" -> "http://192.168.1.104:46445";).toMap
--- End diff --
I feel like these ip's should be something more generic, maybe check if
there any other places in the test code that have strings with ip and ports
that you could copy? Not an actual problem though since whats in the string
only has to match the string below.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
