Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14304#discussion_r71901937
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetEncodingSuite.scala
 ---
    @@ -78,4 +78,30 @@ class ParquetEncodingSuite extends 
ParquetCompatibilityTest with SharedSQLContex
           }}
         }
       }
    +
    +  test("Read row group containing both dictionary and plain encoded 
pages") {
    +    spark.conf.set("parquet.dictionary.page.size", "2048")
    +    spark.conf.set("parquet.page.size", "4096")
    --- End diff --
    
    Let's use `withSQLConf` to alter these settings so that they are 
automatically reverted to their original values at the end of the scope.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to