GitHub user WeichenXu123 opened a pull request:
https://github.com/apache/spark/pull/14335
[SPARK-16697][ML][MLLib] improve LDA submitMiniBatch method to avoid
redundant RDD computation
## What changes were proposed in this pull request?
In `LDAOptimizer.submitMiniBatch`, do persist on `stats: RDD[(BDM[Double],
List[BDV[Double]])]`
and also move the place of unpersisting `expElogbetaBc` broadcast variable,
to avoid the `expElogbetaBc` broadcast variable to be unpersisted too early,
and update previous `expElogbetaBc.unpersist()` into
`expElogbetaBc.destroy(false)`
## How was this patch tested?
Existing test.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/WeichenXu123/spark improve_LDA
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/14335.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #14335
----
commit e5ed33b559a04215c784d0d81a1578d3f13d8804
Author: WeichenXu <weichenxu...@outlook.com>
Date: 2016-07-20T16:39:27Z
improve_LDA
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
