Github user tnachen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14275#discussion_r72003350
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackendUtil.scala
---
@@ -105,16 +105,27 @@ private[mesos] object MesosSchedulerBackendUtil
extends Logging {
def addDockerInfo(
container: ContainerInfo.Builder,
image: String,
+ containerizer: String,
volumes: Option[List[Volume]] = None,
- network: Option[ContainerInfo.DockerInfo.Network] = None,
portmaps: Option[List[ContainerInfo.DockerInfo.PortMapping]] =
None): Unit = {
- val docker = ContainerInfo.DockerInfo.newBuilder().setImage(image)
+ containerizer match {
--- End diff --
Can we have a sensible message/exception when we pass in a unknown
containerizer?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
