Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/14295#discussion_r72013449
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/First.scala
---
@@ -45,6 +45,17 @@ case class First(child: Expression, ignoreNullsExpr:
Expression) extends Declara
override def children: Seq[Expression] = child :: Nil
--- End diff --
Yea, this looks like a cleaner fix. Let me try whether it breaks anything
else. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
